This repository was archived by the owner on Feb 3, 2022. It is now read-only.
Add BTC amounts to transactions list view#40
Open
dawsonc wants to merge 1 commit intosignalapp:masterfrom
Open
Add BTC amounts to transactions list view#40dawsonc wants to merge 1 commit intosignalapp:masterfrom
dawsonc wants to merge 1 commit intosignalapp:masterfrom
Conversation
sesam
referenced
this pull request
in dawsonc/BitHub
Aug 27, 2014
…te views) Add tests for status controller Change TransactionView to display BTC amounts as well as USD. Add Tests Minor Cleanup Added option for viewing past transactions in BTC Fix more merge-related issues
|
@dawsonc you've got some merge conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes PR #15.
Adds BTC transaction amounts to Transaction objects, so that in the transactions list view one will see entries like:
Sent $X USD (Y BTC) to {{destination}} for {{commit}The BTC amounts are also included in the Transaction JSON object.
Also includes unit tests for BTC amounts.
Addresses Issue #11